Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update k8s to v1.23.0 #1910

Closed
wants to merge 1 commit into from
Closed

update k8s to v1.23.0 #1910

wants to merge 1 commit into from

Conversation

Thor-wl
Copy link
Member

@Thor-wl Thor-wl commented Dec 20, 2021

ref: #1665
Signed-off-by: Thor-wl 13164644535@163.com

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 20, 2021
@Thor-wl Thor-wl changed the title update k8s to v1.23.0 [WIP]update k8s to v1.23.0 Dec 20, 2021
@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2021
@Thor-wl
Copy link
Member Author

Thor-wl commented Dec 20, 2021

The CI fails due to the bug of golang v1.16. More details can be referred to kubernetes-sigs/controller-tools#643. It can be resolved by updating golang version to v1.17. I'll give another PR for that.

@Thor-wl Thor-wl mentioned this pull request Dec 20, 2021
Merged
@Thor-wl Thor-wl force-pushed the 1216-k8s1.23.0 branch 2 times, most recently from 3eda7fe to 747efcd Compare December 20, 2021 13:04
@Thor-wl Thor-wl requested review from shinytang6 and william-wang and removed request for k82cn and jasonliu747 December 20, 2021 13:04
@Thor-wl Thor-wl force-pushed the 1216-k8s1.23.0 branch 2 times, most recently from 87699ba to 353514e Compare December 20, 2021 13:31
@william-wang
Copy link
Member

@Thor-wl There is too much files :) Would you like to seperate the vendor in another commit?

@Thor-wl
Copy link
Member Author

Thor-wl commented Dec 21, 2021

@Thor-wl There is too much files :) Would you like to seperate the vendor in another commit?

OK. I'll do that after all the problems resolved.

@Thor-wl
update k8s to v1.23.0
cbaedc8 
Signed-off-by: Thor-wl <13164644535@163.com>
@Thor-wl Thor-wl changed the title [WIP]update k8s to v1.23.0 update k8s to v1.23.0 Dec 21, 2021
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2021
This was referenced Dec 21, 2021
Closed
Merged
Closed
Merged
@Thor-wl Thor-wl mentioned this pull request Jan 12, 2022
Merged
@Thor-wl Thor-wl closed this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@william-wang william-wang Awaiting requested review from william-wang

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Thor-wl @volcano-sh-bot @william-wang