Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin on jupyter_releaser #1232

Merged
merged 1 commit into from Oct 11, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 11, 2022

References

Try removing the pin the dev dependency jupyter_releaser.

jupyter_releaser is already installed during the prep-git release step. This step also runs pip install -q -e ".[dev,test]" which could then reinstall an older version of jupyter_releaser from PyPI.

Some more context in jupyter-server/jupyter_releaser#438.

Code changes

We can try removing the pin on the jupyter_releaser dev dependency for now to see if it can help with the current 0.4.0rc0 release.

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio added this to the 0.4.0 milestone Oct 11, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/voila/jupyter-releaser-version

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 165 <- [195 - 244 - 348] -> 650 85 <- [95 - 115 - 153] -> 255 61 <- [66 - 73 - 91] -> 134 63 <- [69 - 72 - 83] -> 117 2465 <- [2653 - 2683 - 2787] -> 3690 2535 <- [2542 - 2545 - 2647] -> 2931 2602 <- [2647 - 2649 - 2744] -> 3105 2731 <- [2758 - 2829 - 2898] -> 2954 1864 <- [1901 - 1965 - 2005] -> 2096 3626 <- [3717 - 3893 - 4308] -> 5309 9161 <- [9295 - 9354 - 9374] -> 9379 6707 <- [6715 - 6727 - 6739] -> 6759 1347 <- [1444 - 1463 - 1468] -> 1494 2163 <- [2224 - 2230 - 2320] -> 2490
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-10-11 06:52:01.032442428 +0000
+++ /dev/fd/62	2022-10-11 06:52:01.032442428 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8370C",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
-        "l1d": 49152,
-        "l1i": 32768,
-        "l2": 1048576,
-        "l3": 50331648
+        "l1d": 65536,
+        "l1i": 65536,
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology tsc_reliable nonstop_tsc cpuid aperfmperf pni pclmulqdq vmx ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single tpr_shadow vnmi ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves avx512vbmi umip avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq la57 rdpid fsrm arch_capabilities",
-      "governor": "performance",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
+      "governor": "",
       "manufacturer": "Intel®",
-      "model": "106",
-      "physicalCores": 1,
+      "model": "63",
+      "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.8,
-      "speedMax": 2.8,
-      "speedMin": 0.8,
-      "stepping": "6",
+      "speed": 2.4,
+      "speedMax": null,
+      "speedMin": null,
+      "stepping": "2",
       "vendor": "GenuineIntel",
-      "virtualization": true,
+      "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 8337240064
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1020-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.5 LTS",
-      "serial": "5e315a5d28464edda09a5a0a28dbdc25",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio jtpio merged commit 0a60820 into voila-dashboards:main Oct 11, 2022
@jtpio jtpio deleted the jupyter-releaser-version branch October 11, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant