New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Voila configuration option for default kernel environmental variables #1175
Add Voila configuration option for default kernel environmental variables #1175
Conversation
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2022-07-28 13:35:45.958110444 +0000
+++ /dev/fd/62 2022-07-28 13:35:45.958110444 +0000
@@ -4,37 +4,37 @@
"BENCHMARK_REFERENCE": "actual"
},
"browsers": {
- "chromium": "97.0.4666.0"
+ "chromium": "94.0.4595.0"
},
"systemInformation": {
"cpu": {
- "brand": "Xeon® Platinum 8370C",
+ "brand": "Xeon® E5-2673 v3",
"cache": {
- "l1d": 98304,
+ "l1d": 65536,
"l1i": 65536,
- "l2": 2097152,
- "l3": 50331648
+ "l2": 524288,
+ "l3": 31457280
},
"cores": 2,
"family": "6",
- "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+ "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
"governor": "",
"manufacturer": "Intel®",
- "model": "106",
+ "model": "63",
"physicalCores": 2,
"processors": 1,
"revision": "",
"socket": "",
- "speed": 2.8,
+ "speed": 2.4,
"speedMax": null,
"speedMin": null,
- "stepping": "6",
+ "stepping": "2",
"vendor": "GenuineIntel",
"virtualization": false,
"voltage": ""
},
"mem": {
- "total": 7281008640
+ "total": 7291699200
},
"osInfo": {
"arch": "x64",
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.15.0-1014-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
- "release": "20.04.4 LTS",
- "serial": "6acefdd3c3134d8096096c3373e75e18",
+ "release": "20.04.3 LTS",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
Thanks @dcnadler for your contribution, for now, setting the default environmental variables for the pre-heated kernel is possible by configuring the
It's pretty verbose so I think we can make |
Thanks @trungleduc! Did not realize that was an option. I am new to trailets. Seems like trailets may not let you pass a nested dict in the future?
I moved the |
Thanks! |
Currently, to use partially pre-rendered notebooks a user may have to set environmental variables in notebook kernels to access the correct websocket address.
The docs give the example of using
voila.json
to set these. However, for some deployment platforms these values (e.g. base_url or port) may not be known ahead of time or differ between deployments. Having a command line option provides easier passing of env variables (as opposed to modifyingvoila.json
in-place).Code changes
A
default_kernel_env_variables
attribute is added toVoilaConfiguration
, which is then passed to the defaultkernel_pools_config
ofVoilaKernelManager
.