Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gui): enable DPI awareness to avoid bad resolution #1125

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ACGNnsj
Copy link

@ACGNnsj ACGNnsj commented Mar 13, 2024

Description of change

copilot:all

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request follows Contributing.md
  • This pull request links relevant issues as Fixes #0000
  • pre-commit run -a passes with this change or ci passes
  • poetry run pytest passes with this change or ci passes
  • (There are new or updated unit tests validating the change)
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 19.22%. Comparing base (3f537b0) to head (9abacba).

Files Patch % Lines
src/so_vits_svc_fork/gui.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   19.25%   19.22%   -0.03%     
==========================================
  Files          39       39              
  Lines        3496     3500       +4     
  Branches      497      498       +1     
==========================================
  Hits          673      673              
- Misses       2804     2808       +4     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@34j 34j changed the title Enable DPI awareness to avoid bad resolution feat(gui): enable DPI awareness to avoid bad resolution Mar 30, 2024
@34j
Copy link
Collaborator

34j commented Apr 6, 2024

This change makes the window to be too small, so the window scale needs to be changed accordingly, but it's a pain to do this
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants