Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed critical typo in sysctl.d config #1498

Open
wants to merge 2 commits into
base: photon-hugo
Choose a base branch
from

Conversation

MajorTwip
Copy link

typo prevents /etc/systctl.d/kubernetes.yaml to be loaded by sysctl --system and therefore breaks the cluster networking.

replaced "/" with "."
replaced "/" with "."
@vmwclabot
Copy link
Member

@MajorTwip, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@MajorTwip, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@MajorTwip MajorTwip changed the title Fixed critical type in sysctl.d config Fixed critical typo in sysctl.d config Jul 23, 2023
@sshedi
Copy link
Contributor

sshedi commented Jul 24, 2023

@prashant1221 can you please take this fix?
cc: @tapakund

@vmwclabot
Copy link
Member

@MajorTwip, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Can you please update your address with town/city, state and country ?

@vmwclabot
Copy link
Member

@MajorTwip, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@MajorTwip, VMware has approved your signed contributor license agreement.

@prashant1221
Copy link
Contributor

LGTM, I'll take the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants