Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release automation #2877

Merged
merged 1 commit into from Jun 16, 2022
Merged

Update release automation #2877

merged 1 commit into from Jun 16, 2022

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented Jun 15, 2022

Description

Updates the release automation workflow to incorporate required automation changes introduced by PR #2872 .

Starting with release v0.29.0 (strictly speaking with the commit when this PR is merged to master), the release automation will not use tags to trigger the workflow anymore but release branches, e.g. release-0.29. The whole process is done through the Github UI (only a release branch needs to be created upfront) using a workflow_dispatch trigger . See RELEASE.md for all details.

A dry-run mode is available (default) to simulate a release without pushing/creating artifacts, etc. This would detect most (but not all) issues during a release.

This streamlines the release process for patch/maintenance (e.g. v0.29.1 on release-0.29) and new releases (e.g. release-0.30).

Warning

Due to the way the release automation is triggered and the workflows are resolved, it is important to understand that this new process only works for releases after this PR is merged. For any cherry-pick/back-ports, e.g. v0.28.x or older, the release workflow would resolve to the older version, i.e. the one trigged by pushing a corresponding v... commit.

The release instructions were updated to reflect these changes and describe different scenarios for new/older releases.

Closes: #2875
Signed-off-by: Michael Gasch mgasch@vmware.com

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Run various E2E deployments in a separate repo with branch protection - but I could not simulate everything so we might have to patch this one if we encounter issues under the vmware repo

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Closes: vmware#2875
Signed-off-by: Michael Gasch <mgasch@vmware.com>
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @embano1 , lgtm

@embano1 embano1 changed the title chore: Update release automation Update release automation Jun 16, 2022
@embano1 embano1 marked this pull request as ready for review June 16, 2022 13:20
@embano1 embano1 merged commit 63aa05d into vmware:master Jun 16, 2022
@embano1 embano1 deleted the issue-2875 branch June 16, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release automation
3 participants