Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: govc-tests in Go v1.18 #2866

Merged
merged 1 commit into from Jun 1, 2022
Merged

fix: govc-tests in Go v1.18 #2866

merged 1 commit into from Jun 1, 2022

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented Jun 1, 2022

Description

The previous workaround to support Go v1.18 is not needed anymore and in fact now breaks the CI during the govc vcsim examples tests. Removing it.

Closes: #2865
Signed-off-by: Michael Gasch mgasch@vmware.com

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • CI passes for govc-tests for vcsim examples with Go 1.18

Note that certain jobs still fail bc they're the usual flakes. This is not addressed with this PR.

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Closes: vmware#2865
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@embano1 embano1 requested a review from dougm June 1, 2022 14:16
@embano1 embano1 marked this pull request as ready for review June 1, 2022 14:17
@embano1 embano1 merged commit 3609b5e into vmware:master Jun 1, 2022
@embano1 embano1 deleted the issue-2865 branch June 1, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

govc-tests broken on Go v1.18 leg
3 participants