Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright boilerplate check #2863

Merged
merged 2 commits into from Jun 1, 2022
Merged

Add copyright boilerplate check #2863

merged 2 commits into from Jun 1, 2022

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented May 30, 2022

Description

  • Runs copyright header check against every new/modified file
  • Update files with missing copyright header (I did not change the ones in vim25 since those are copies from Go src)

Closes: #2749 #2713

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Verified that Reviewdog fails when license header is not present in a .go file

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Michael Gasch added 2 commits May 31, 2022 15:33
Closes: vmware#2749

Closes: vmware#2713
Signed-off-by: Michael Gasch <mgasch@vmware.com>
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@embano1 embano1 changed the title WIP Add copyright boilerplate check May 31, 2022
@embano1 embano1 marked this pull request as ready for review May 31, 2022 14:00
@embano1 embano1 requested a review from dougm May 31, 2022 14:00
@embano1
Copy link
Contributor Author

embano1 commented May 31, 2022

@dougm I created two commits, one which adds missing header, the other one for the CI part to simplify your review.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@embano1 embano1 merged commit 93aac39 into vmware:master Jun 1, 2022
@embano1 embano1 deleted the issue-2749 branch June 10, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check boilerplate workflow
3 participants