Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Check for existing Tanzu Builder and use if there #4641

Conversation

codegold79
Copy link
Contributor

What this PR does / why we need it

Although it's not the recommended way to download and use Tanzu CLI Plugin Builder, this PR provides a direct way to obtain the builder binary and use it. It bypasses using Tanzu CLI altogether.

Which issue(s) this PR fixes

Fixes #4640

Describe testing done for PR

Release note


Additional information

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #4641 (9c63c74) into main (7fa2b72) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4641      +/-   ##
==========================================
+ Coverage   75.06%   75.33%   +0.26%     
==========================================
  Files          21       21              
  Lines        1199     1212      +13     
==========================================
+ Hits          900      913      +13     
  Misses        249      249              
  Partials       50       50              

see 2 files with indirect coverage changes

@codegold79 codegold79 marked this pull request as ready for review July 1, 2023 16:29
@codegold79 codegold79 requested a review from a team as a code owner July 1, 2023 16:29
Copy link
Contributor

@avi-08 avi-08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codegold79 codegold79 added the ok-to-merge PRs should be labelled with this before merging label Jul 4, 2023
Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79 codegold79 force-pushed the TRC-164_Use-existing-Tanzu-CLI-Builder-if-provided branch from b615323 to 9c63c74 Compare July 5, 2023 22:42
@codegold79
Copy link
Contributor Author

Sorry, @avi-08, I should've put my latest change into a separate commit where I put the tanzu-builder into a new directory, tanzu-cli. I wasn't thinking and just did a rebase. But should be easy enough to re-review.

@codegold79 codegold79 requested a review from avi-08 July 5, 2023 22:48
@codegold79 codegold79 merged commit 93a508a into vmware-tanzu:main Jul 7, 2023
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for existing Tanzu Builder and use if there
5 participants