This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Extending readiess e2e tests with custom service account scenario #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4639 +/- ##
=======================================
Coverage 75.33% 75.33%
=======================================
Files 21 21
Lines 1212 1212
=======================================
Hits 913 913
Misses 249 249
Partials 50 50 |
avi-08
approved these changes
Jun 28, 2023
rajathagasthya
approved these changes
Jun 28, 2023
rajathagasthya
added
the
ok-to-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
There were recent changes added that enables configuring the service account with which the providers will execute the query. In this PR, we are adding a end-to-end test to include the service account scenario.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
End-to-End tests!
Release note
Additional information
Special notes for your reviewer