pinniped-components: Extract GetPinnipedKubeconfig and oFromCluster to shared lib #4533
Conversation
|
Cluster Generation A/B Results: |
|
Love the idea. Let's get the PR checks ✅ and ask for approval. Do we need the change to the root |
…oFromCluster to shared lib
benjaminapetersen
force-pushed
the
pinniped-components/GetPinnipedKubeconfig-GetPinnipedInfoFromCluster
branch
from
dc7be06
to
c9090f8
Compare
|
CVE Scan results for this PR can be viewed from |
|
You have successfully added a new Trivy configuration |
|
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
|
Think all the |
There was a problem hiding this comment.
Thank you @benjaminapetersen. It's really great to see this refactoring.
I would wait for CI checks to pass before merging.
| @@ -377,6 +377,8 @@ func createServerWithEndpoint() (server *configapi.Server, err error) { | |||
| return nil, err | |||
| } | |||
| } else { | |||
| // TODO(BEN): this func has more complicated dependencies, but is obviouisly pinniped related, and it is | |||
There was a problem hiding this comment.
After this func is refactored, it would really help core CLI to fetch pinniped kubeconfig by providing the endpoint.
Infact Core CLI would really need this functionality (in pinniped-components/common) where given endpoint to TKG/TKGs cluster library would return the pinniped kubeconfig. So that CLI could fully depend on the library and remove duplicated code.
There was a problem hiding this comment.
@prkalle if you happen to already have a good eye on all the require() and replace() across this repo and the various modules from you previous work, would love any pointers. I think some of the replace() statements are causing incompatibility issues. Tracking that down next, is breaking the build.
There was a problem hiding this comment.
Sure @benjaminapetersen. We can discuss offline.
Extract GetPinnipedKubeconfig and oFromCluster to shared lib
Continuing with what we began in #4514 this extracts two common functions for interactions with Pinniped and deduplicates them.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer