Address security alerts #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated golang.org/x/net to v0.7.0 and golang.org/x/text v0.7.0 in hack/samples/go.mod file
Testing done:
acharyasrePHTDD:vmware-tanzu-image-registry-operator-api acharyasreej$ make all
/Library/Developer/CommandLineTools/usr/bin/make lint-go-full
make -C hack/tools golangci-lint
go build -tags=tools -o bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
hack/tools/bin/golangci-lint run -v --fast=false
INFO [config_reader] Config search paths: [./ /Users/acharyasreej/GitRepos/vmware-tanzu-image-registry-operator-api /Users/acharyasreej/GitRepos /Users/acharyasreej /Users /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 32 linters: [asciicheck bodyclose deadcode depguard dogsled errcheck exportloopref goconst gocritic gocyclo godot gofmt goimports goprintffuncname gosec gosimple govet importas ineffassign nakedret nilerr nolintlint prealloc revive rowserrcheck staticcheck structcheck stylecheck typecheck unconvert unparam varcheck]
INFO [loader] Go packages loading at mode 575 (types_sizes|compiled_files|deps|exports_file|files|imports|name) took 546.368528ms
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 5.572029ms
INFO [linters_context/goanalysis] analyzers took 0s with no stages
WARN [linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.
WARN [linters_context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.
INFO [runner] Issues before processing: 9, after processing: 0
INFO [runner] Processors filtering stat (out/in): exclude: 9/9, exclude-rules: 0/9, path_prettifier: 9/9, identifier_marker: 9/9, skip_dirs: 9/9, filename_unadjuster: 9/9, skip_files: 9/9, autogenerated_exclude: 9/9, cgo: 9/9
INFO [runner] processing took 1.238679ms with stages: autogenerated_exclude: 744.768µs, identifier_marker: 211.352µs, path_prettifier: 110.261µs, exclude: 46.484µs, exclude-rules: 34.893µs, skip_files: 33.878µs, skip_dirs: 23.697µs, cgo: 22.801µs, nolint: 5.939µs, max_same_issues: 1.195µs, filename_unadjuster: 1.167µs, uniq_by_line: 465ns, source_code: 282ns, max_from_linter: 264ns, max_per_file_from_linter: 241ns, diff: 234ns, severity-rules: 233ns, sort_results: 204ns, path_shortener: 176ns, path_prefixer: 145ns
INFO [runner] linters took 1.269533347s with stages: goanalysis_metalinter: 1.268153709s, rowserrcheck: 18.117µs, structcheck: 6.583µs
INFO File cache stats: 0 entries of total size 0B
INFO Memory: 20 samples, avg is 39.1MB, max is 53.3MB
INFO Execution took 1.83662009s
/Library/Developer/CommandLineTools/usr/bin/make lint-markdown
docker run --rm -v $(pwd):/mnt mivok/markdownlint -c /mnt/.mdlrc /mnt
make -C hack/tools controller-gen
go build -tags=tools -o bin/controller-gen sigs.k8s.io/controller-tools/cmd/controller-gen
make -C hack/tools golangci-lint
go build -tags=tools -o bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
make -C hack/tools setup-envtest
GOBIN=/Users/acharyasreej/GitRepos/vmware-tanzu-image-registry-operator-api/hack/tools/bin go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
./bin/setup-envtest --bin-dir /Users/acharyasreej/GitRepos/vmware-tanzu-image-registry-operator-api/hack/tools/bin -p path use
/Users/acharyasreej/GitRepos/vmware-tanzu-image-registry-operator-api/hack/tools/bin/k8s/1.26.1-darwin-amd64/Library/Developer/CommandLineTools/usr/bin/make generate-go
make -C hack/tools controller-gen
go build -tags=tools -o bin/controller-gen sigs.k8s.io/controller-tools/cmd/controller-gen
hack/tools/bin/controller-gen
paths=./api/...
object:headerFile="/Users/acharyasreej/GitRepos/vmware-tanzu-image-registry-operator-api/hack/boilerplate/boilerplate.go.txt"
go generate ./...
/Library/Developer/CommandLineTools/usr/bin/make generate-manifests
make -C hack/tools controller-gen
go build -tags=tools -o bin/controller-gen sigs.k8s.io/controller-tools/cmd/controller-gen
hack/tools/bin/controller-gen
paths=./api/...
crd:crdVersions=v1
output:crd:dir=config/crd/bases
output:none
acharyasrePHTDD:vmware-tanzu-image-registry-operator-api acharyasreej$