This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Adds Version to unmanaged-cluster plugin descriptor
#2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
reviewed
Jan 10, 2022
jpmcb
force-pushed
the
unmanaged-version
branch
from
2cffd77
to
cda061c
Compare
jpmcb
commented
Jan 10, 2022
Signed-off-by: John McBride <jmcbride@vmware.com>
jpmcb
force-pushed
the
unmanaged-version
branch
from
cda061c
to
dae7b42
Compare
|
@joshrosso & @stmcginnis - this should be ready for review now! |
nrb
approved these changes
Jan 11, 2022
|
Code looks good, but failing Go style checks. |
I think that's something we'll have to address on the |
joshrosso
approved these changes
Jan 12, 2022
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
Signed-off-by: John McBride <jmcbride@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds
Versionto the plugin descriptor forunmanaged-clusterusing thebuildinfo.Versioncompile time flag fromtanzu-frameworkv0.10.0Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
N/a
Describe testing done for PR
Now able to build from the
standalone-overhaulbranch usingmake build-cli-plugins-localSpecial notes for your reviewer
N/a