Adding testing for survey prompts #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashedkvm
reviewed
Mar 31, 2022
There was a problem hiding this comment.
Few tests are flaky and failing. It may be related to AlecAivazis/survey#406. Can we remove the flaky tests for now? We can add more tests oncel a proper fix for AlecAivazis/survey#406 is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Add test for survey prompts. Initial approach was created by @suarezjulian. There were some changes to dependency libraries added in this PR. Checking if the current versions of upstream libraries have solved the error this approach had in Linux systems.
Which issue(s) this PR fixes
Fixes #36
Describe testing done for PR
Additional information or special notes for your reviewer
Signed-off by: Wendy Arango warango@vmware.com