Updating VIB GitHub Action to Node.js 20 (#169)

* Updating VIB GitHub Action to Node.js 20 --------- Signed-off-by: Gloria Delgado <gloriad@vmware.com>
vmware-labs · Feb 8, 2024 · f325790 · f325790
1 parent f4e9113
commit f325790
Show file tree

Hide file tree

Showing 14 changed files with 27,019 additions and 7,960 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -17,10 +17,10 @@ jobs:
         with:
           token: ${{ secrets.VIB_ACTION_TOKEN }}
 
-      - name: Set Node.js 16.x
+      - name: Set Node.js 20
         uses: actions/setup-node@v2
         with:
-          node-version: 16.x
+          node-version: 20.x
 
       - name: Git config
         run: |

diff --git a/.github/workflows/validate.yaml b/.github/workflows/validate.yaml
@@ -23,10 +23,10 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v2
 
-    - name: Set Node.js 16.x
+    - name: Set Node.js 20
       uses: actions/setup-node@v2
       with:
-        node-version: 16.x
+        node-version: 20.x
 
     - name: Install dependencies
       run: npm ci

diff --git a/__tests__/src/action.it.test.ts b/__tests__/src/action.it.test.ts
@@ -6,7 +6,7 @@ import fs from 'fs'
 
 const TWO_MINUTES = 1200000
 
-jest.spyOn(core, 'setFailed')
+jest.spyOn(core, 'setFailed').mockImplementation()
 
 describe('Given a VIB Action', () => {
 

diff --git a/__tests__/src/action.test.ts b/__tests__/src/action.test.ts
@@ -18,7 +18,7 @@ jest.mock('../../src/client/vib')
 jest.spyOn(artifact, 'create')
 jest.spyOn(core, 'error')
 jest.spyOn(core, 'info')
-jest.spyOn(core, 'setFailed')
+jest.spyOn(core, 'setFailed').mockImplementation()
 jest.spyOn(core, 'warning')
 
 const STARTING_ENV = process.env

diff --git a/__tests__/src/client/clients.test.ts b/__tests__/src/client/clients.test.ts
@@ -16,7 +16,7 @@ describe("Given a custom client", () => {
     jest.spyOn(core, "info").mockImplementation(msg => console.log("::info:: " + msg))
     jest.spyOn(core, "warning").mockImplementation(msg => console.log("::warning:: " + msg))
     jest.spyOn(core, "debug").mockImplementation(msg => console.log("::debug:: " + msg))
-    jest.spyOn(core, "setFailed")
+    jest.spyOn(core, "setFailed").mockImplementation()
   })
 
   beforeEach(async () => {

diff --git a/__tests__/src/client/csp.test.ts b/__tests__/src/client/csp.test.ts
@@ -11,7 +11,7 @@ describe("Given a CSP client", () => {
     jest.spyOn(core, "info").mockImplementation(msg => console.log("::info:: " + msg))
     jest.spyOn(core, "warning").mockImplementation(msg => console.log("::warning:: " + msg))
     jest.spyOn(core, "debug").mockImplementation(msg => console.log("::debug:: " + msg))
-    jest.spyOn(core, "setFailed")
+    jest.spyOn(core, "setFailed").mockImplementation()
   })
 
   beforeEach(async () => {

diff --git a/__tests__/src/config.test.ts b/__tests__/src/config.test.ts
@@ -12,7 +12,7 @@ describe("Given a configuration", () => {
     jest.spyOn(core, "info").mockImplementation(msg => console.log("::info:: " + msg))
     jest.spyOn(core, "warning").mockImplementation(msg => console.log("::warning:: " + msg))
     jest.spyOn(core, "debug").mockImplementation(msg => console.log("::debug:: " + msg))
-    jest.spyOn(core, "setFailed")
+    jest.spyOn(core, "setFailed").mockImplementation()
   })
 
   beforeEach(() => {

diff --git a/action.yml b/action.yml
@@ -54,7 +54,7 @@ outputs:
   result:
     description: 'The resulting report from the execution graph with tasks executed and their statuses.'
 runs:
-  using: 'node16'
+  using: 'node20'
   main: 'dist/index.js'
 branding:
   icon: 'command'