List children exactly once for ChildSetReconciler #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the ChildSetReconciler would list children once for the set and again for each child being reconciled. At best this was inefficient, at worst it introduced subtile issues when the content of the listing changed over the course of the reconcile. Now the content of the list from the ChildSetReconciler is reused by each child that is reconciled. Signed-off-by: Scott Andrews <scott@andrews.me>
|
cc @squeedee |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
- Coverage 61.18% 61.13% -0.06%
==========================================
Files 28 28
Lines 2566 2583 +17
==========================================
+ Hits 1570 1579 +9
- Misses 909 917 +8
Partials 87 87 ☔ View full report in Codecov by Sentry. |
mamachanko
approved these changes
Mar 9, 2024
squeedee
reviewed
Mar 11, 2024
|
I really like the calledAtMostTimes solution for the test. |
|
I went back to the state of my project that caused me to raise this issue, passing 2/10 times, then pointed at this branch and reran, got 10/10 passes, so I have a lot of confidence this resolves the issue. Thanks! |
squeedee
approved these changes
Mar 11, 2024
|
@scothis, VMware has approved your signed contributor license agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ChildSetReconciler would list children once for the set and again for each child being reconciled. At best this was inefficient, at worst it introduced subtile issues when the content of the listing changed over the course of the reconcile.
Now the content of the list from the ChildSetReconciler is reused by each child that is reconciled.
Resolves #481