Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require ListOptions when SkipOwnerReference is true #493

Merged
merged 1 commit into from Mar 7, 2024
Merged

Require ListOptions when SkipOwnerReference is true #493

merged 1 commit into from Mar 7, 2024

Commits on Mar 6, 2024

  1. Require ListOptions when SkipOwnerReference is true 

    The most common reason to disable owner references for a child resource
is when that resource is in a different namespace. In that case, the
default ListOptions (filter by the parent's namespace) is ineffective
and will orphan the child resource.

We now validate that ListOptions is defined when SkipOwnerReference is
true and fail fast.

Signed-off-by: Scott Andrews <scott@andrews.me>
    @scothis
    scothis committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    8d95557 View commit details
    Browse the repository at this point in the history