Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom cmp.Options when comparing k8s objects #485

Closed

Conversation

neowulf
Copy link

@neowulf neowulf commented Feb 23, 2024

This fix allows adding custom comparator options and is especially useful when non standard k8s objects are used and may require custom comparators.

Resolves #484

fix 484

Signed-off-by: Siva Kommuri <siva.kommuri@broadcom.com>
@vmwclabot
Copy link

@neowulf, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@neowulf neowulf changed the title Add custom cmp.Options when comparing k8s objects DRAFT: Add custom cmp.Options when comparing k8s objects Feb 23, 2024
@neowulf neowulf changed the title DRAFT: Add custom cmp.Options when comparing k8s objects Add custom cmp.Options when comparing k8s objects Feb 23, 2024
@neowulf neowulf marked this pull request as draft February 23, 2024 17:03
@neowulf neowulf marked this pull request as ready for review February 23, 2024 17:21
@neowulf neowulf closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panics when comparing objects with unexported fields
2 participants