Allow access to known children in ChildSetReconciler#DesiredChildren #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 60.54% 60.67% +0.13%
==========================================
Files 26 26
Lines 2532 2543 +11
==========================================
+ Hits 1533 1543 +10
- Misses 910 911 +1
Partials 89 89 ☔ View full report in Codecov by Sentry. |
Current known children can be obtained via RetrieveKnownChildren[ChildType](ctx). This can be used to keep existing children while stamping out new resources, or for garbage collecting resources based on some criteria. Return the children that should be kept and omit children to delete. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
scothis
force-pushed
the
known-children
branch
from
81ab1d3
to
a8abd38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current known children can be obtained via RetrieveKnownChildren(ctx). This can be used to keep existing children while stamping out new resources, or for garbage collecting resources based on some criteria. Return the children that should be kept and omit children to delete.