Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demonstration of a possible oversight #456

Closed

Conversation

squeedee
Copy link
Collaborator

@squeedee squeedee commented Nov 8, 2023

Just wonder if this layering (through a shadowed ctx) was intentional or an oversight?

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4d2708) 60.54% compared to head (72f8a95) 60.54%.

❗ Current head 72f8a95 differs from pull request most recent head a24f659. Consider uploading reports for the commit a24f659 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   60.54%   60.54%           
=======================================
  Files          26       26           
  Lines        2532     2532           
=======================================
  Hits         1533     1533           
  Misses        910      910           
  Partials       89       89           
Files Coverage Δ
reconcilers/sequence.go 55.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scothis
Copy link
Contributor

scothis commented Nov 8, 2023

Intentional, see #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants