Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: duck type support for builder calls - still need to deal with client.… #450

Closed
wants to merge 2 commits into from

Conversation

squeedee
Copy link
Collaborator

@squeedee squeedee commented Nov 2, 2023

…Create not working

@squeedee squeedee changed the title duck type support for builder calls - still need to deal with client.… Draft: duck type support for builder calls - still need to deal with client.… Nov 2, 2023
@squeedee squeedee marked this pull request as draft November 2, 2023 22:48
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c994cf2) 60.65% compared to head (7ce0492) 60.41%.

❗ Current head 7ce0492 differs from pull request most recent head 4131229. Consider uploading reports for the commit 4131229 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   60.65%   60.41%   -0.24%     
==========================================
  Files          26       26              
  Lines        2524     2534      +10     
==========================================
  Hits         1531     1531              
- Misses        904      914      +10     
  Partials       89       89              
Files Coverage Δ
reconcilers/child.go 79.22% <0.00%> (-5.51%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scothis
Copy link
Contributor

scothis commented Nov 2, 2023

Duck types are inherently interfaces that project a subset of a resource. Thus they cannot be used in places where a fully defined resource is required. Like Create and Update operations.

This behavior is documented at the top of the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants