Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic bits from types that are not generic #448

Merged
merged 1 commit into from Oct 23, 2023

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Oct 23, 2023

No description provided.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23bb46d) 60.65% compared to head (4ffedc8) 60.65%.

❗ Current head 4ffedc8 differs from pull request most recent head 6bdb1cf. Consider uploading reports for the commit 6bdb1cf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   60.65%   60.65%           
=======================================
  Files          26       26           
  Lines        2524     2524           
=======================================
  Hits         1531     1531           
  Misses        904      904           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mamachanko mamachanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. That was an oversight. Thanks for adjusting!

@scothis scothis merged commit 92d8131 into vmware-labs:main Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants