Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify ChildSetReconciler doc #444

Merged
merged 1 commit into from Oct 16, 2023
Merged

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Oct 16, 2023

No description provided.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Copy link
Collaborator

@squeedee squeedee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks man!

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1850729) 60.65% compared to head (de446fd) 60.65%.

❗ Current head de446fd differs from pull request most recent head 3f8b0ac. Consider uploading reports for the commit 3f8b0ac to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   60.65%   60.65%           
=======================================
  Files          26       26           
  Lines        2524     2524           
=======================================
  Hits         1531     1531           
  Misses        904      904           
  Partials       89       89           
Files Coverage Δ
reconcilers/childset.go 87.87% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scothis scothis merged commit 23bb46d into vmware-labs:main Oct 16, 2023
4 checks passed
@scothis scothis deleted the clarify-child-set branch October 16, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants