Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track controller-runtime 0.15 development #356

Merged
merged 4 commits into from May 12, 2023

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Apr 12, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 30.76% and project coverage change: -1.81 ⚠️

Comparison is base (615186e) 59.74% compared to head (387de98) 57.94%.

❗ Current head 387de98 differs from pull request most recent head 4492479. Consider uploading reports for the commit 4492479 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   59.74%   57.94%   -1.81%     
==========================================
  Files          16       14       -2     
  Lines        2124     1964     -160     
==========================================
- Hits         1269     1138     -131     
+ Misses        773      748      -25     
+ Partials       82       78       -4     
Impacted Files Coverage Δ
reconcilers/enqueuer.go 0.00% <0.00%> (ø)
reconcilers/reconcilers.go 75.75% <0.00%> (-0.40%) ⬇️
testing/client.go 54.04% <0.00%> (-0.94%) ⬇️
testing/reconciler.go 0.00% <0.00%> (ø)
testing/subreconciler.go 0.00% <0.00%> (ø)
testing/webhook.go 0.00% <0.00%> (ø)
testing/config.go 87.50% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
An upstream change in the fake client now distinguishes between
patch/update requests to resource with a status sub-resource and those
without.

Requests made to a resource with the status sub-resource at the main
resource are not able to mutate the status, and requests made to the
status sub-resource are only able to modify the status.

Requests using the status sub-resource to types that have not indicated
they support the status sub-resource will return a not found error.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis marked this pull request as ready for review May 12, 2023 19:17
@scothis scothis merged commit 8d2cd3b into vmware-labs:main May 12, 2023
1 check passed
@scothis scothis deleted the controller-runtime-0.15 branch May 12, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants