Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ChildReconciler to work without owner references #235

Merged
merged 2 commits into from May 16, 2022

Commits on May 13, 2022

  1. Allow ChildReconciler to work without owner references

    Owner references only work within the same namespace (or cluster scope).
    Finalizers give us the ability to clean up state in other scopes, where
    owner references are not valid.
    
    ChildReconciler can now opt-out of owner references with
    SkipOwnerReference, using a child Finalizer implies SkipOwnerReference.
    Since we can no longer link parent and child resources via the owner
    reference, the child is tracked explicitly and the OurChild method must
    be defined and able to uniquely distinguish the child resource that
    belongs to the parent from other resources of the same kind.
    
    Signed-off-by: Scott Andrews <andrewssc@vmware.com>
    scothis committed May 13, 2022
    Copy the full SHA
    7d7e73d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. review feedback

    Signed-off-by: Scott Andrews <andrewssc@vmware.com>
    scothis committed May 16, 2022
    Copy the full SHA
    0089c31 View commit details
    Browse the repository at this point in the history