Include reconciler name in validation errors #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamachanko
force-pushed
the
better-must-implement-errors
branch
from
19935b5
to
db7bd0f
Compare
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 65.07% 65.07%
=======================================
Files 9 9
Lines 1008 1008
=======================================
Hits 656 656
Misses 330 330
Partials 22 22
Continue to review full report at Codecov.
|
scothis
reviewed
May 9, 2022
- all reconciler are now named - include reconciler type/name in field validation that is a nil check Signed-off-by: Scott Andrews <andrewssc@vmware.com>
scothis
force-pushed
the
better-must-implement-errors
branch
from
db7bd0f
to
11d1639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to find invalid reconcilers by including the offending reconciler's name in the error message.