Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OurChild to make decisions with the parent and child objects #221

Merged
merged 1 commit into from May 4, 2022

Conversation

scothis
Copy link
Contributor

@scothis scothis commented May 3, 2022

This is a breaking change, but OurChild was fairly useless without
knowing the parent resource that that child resource is owned by.

Resolves #216

This is a breaking change, but OurChild was fairly useless without
knowing the parent resource that that child resource is owned by.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #221 (da87370) into main (3382f72) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head da87370 differs from pull request most recent head 8f4aad4. Consider uploading reports for the commit 8f4aad4 to get more accurate results

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   62.14%   62.18%   +0.04%     
==========================================
  Files           9        9              
  Lines         906      907       +1     
==========================================
+ Hits          563      564       +1     
  Misses        325      325              
  Partials       18       18              
Impacted Files Coverage Δ
reconcilers/reconcilers.go 80.03% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3382f72...8f4aad4. Read the comment docs.

Copy link
Collaborator

@mamachanko mamachanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scothis LGTM! 👍🏻

@scothis scothis merged commit 91fe232 into vmware-labs:main May 4, 2022
@scothis scothis deleted the our-child branch May 4, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OurChild may need parent
3 participants