Add RBAC recommendations for controllers #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent and child reconciler each make client requests based on the resources being reconciled. We should give guidance to users as to what RBAC permissions are required to effectively use the reconcilers. The RBAC permissions are defined as kubebuilder annotations that can be parsed and converted into a ClusterRole via controller-gen. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 62.14% 66.72% +4.58%
==========================================
Files 9 9
Lines 906 1136 +230
==========================================
+ Hits 563 758 +195
- Misses 325 354 +29
- Partials 18 24 +6
Continue to review full report at Codecov.
|
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent and child reconciler each make client requests based on the
resources being reconciled. We should give guidance to users as to what
RBAC permissions are required to effectively use the reconcilers.
The RBAC permissions are defined as kubebuilder annotations that can be
parsed and converted into a ClusterRole via controller-gen.
Resolves #217