Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Factories to Dies #175

Merged
merged 1 commit into from Jan 3, 2022
Merged

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Dec 23, 2021

This completes the removal of the factory types that were deprecated in
v0.4.0. dies.dev dies are now used as a replacement.

Refs #160

Signed-off-by: Scott Andrews andrewssc@vmware.com

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #175 (863adfe) into main (8c74a21) will decrease coverage by 0.96%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   66.53%   65.56%   -0.97%     
==========================================
  Files           7        8       +1     
  Lines         747      758      +11     
==========================================
  Hits          497      497              
- Misses        235      246      +11     
  Partials       15       15              
Impacted Files Coverage Δ
internal/resources/dies/dies.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c74a21...863adfe. Read the comment docs.

This completes the removal of the factory types that were deprecated in
v0.4.0. dies.dev dies are now used as a replacement.

Refs #160

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis merged commit df6827f into vmware-labs:main Jan 3, 2022
@scothis scothis deleted the drop-factories branch January 3, 2022 13:44
@scothis scothis mentioned this pull request Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants