Add missing parent to invocation of ChildReconciler.OurChild (#229)

vmware-labs · May 9, 2022 · 18bf0bb · 18bf0bb
1 parent af55ebc
commit 18bf0bb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/reconcilers/reconcilers.go b/reconcilers/reconcilers.go
@@ -1072,6 +1072,7 @@ func (r *ChildReconciler) ourChild(parent, obj client.Object) bool {
 	}
 	fn := reflect.ValueOf(r.OurChild)
 	out := fn.Call([]reflect.Value{
+		reflect.ValueOf(parent),
 		reflect.ValueOf(obj),
 	})
 	keep := true

diff --git a/reconcilers/reconcilers_test.go b/reconcilers/reconcilers_test.go
@@ -930,7 +930,7 @@ func TestChildReconciler(t *testing.T) {
 		Metadata: map[string]interface{}{
 			"SubReconciler": func(t *testing.T, c reconcilers.Config) reconcilers.SubReconciler {
 				r := defaultChildReconciler(c)
-				r.OurChild = func(child *corev1.ConfigMap) bool {
+				r.OurChild = func(parent *resources.TestResource, child *corev1.ConfigMap) bool {
 					return false
 				}
 				return r