Remove non-required ClientOptResolver option usage
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
3 tasks
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
|
ping @juamedgod / @alemorcuq :P Edit: as per an offline sync, they will go ahead with the change if Helm decides to effectively migrate to ORAS v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kubeapps, we needed to add a new
ClientOptResolveroption in the Helm project (context here). However, this is mostly for tests and other non-typical use-cases.The current
NewClientfunction in Helm is setting the required options in the autorizer, so there is no need to manually set the resolver (see the code)This PR is mainly remove those redundant piece of code, so that
ClientOptResolveris not used anymore.The rationale behind the change is in helm/helm#12310 (comment). In short, this is blocking a potential upgrade from ORAS v1 to v2 at Helm's side.