Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconstant List Indentation #616

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on May 20, 2017

  1. Create test for issue vmg#615

    Jason DeLeon committed May 20, 2017
    Configuration menu
    Copy the full SHA
    174edcd View commit details
    Browse the repository at this point in the history
  2. Correct an issue where the list parser would improperly handle indent…

    …ation
    
    By observing the data available at work->data, an interesting observation was noted that causes the tracking of indentation to be improperly handled. Specifically, the indentation on Item 3 appears to be handled incorrectly, which causes issues when scanning on the next iteration, from Item 2 downward.
    
    To correct this, indentation is first handled as normal, checking up to four characters. We do this by initializing pre to our starting value, 4, then perform the indentation check using pre instead of the fixed value. Since pre is being updated constantly, this allows us to take the current indent and use it to properly crawl the list.
    
    An interesting note is that the test for this issue will fail if you add a sixth-level item. This is due to max_nesting and how nesting is tracked on lists. On a linear list, a max_nesting of (1 + 2 + ... + n) is required, with n being the furthest nesting level. By default, max_nesting is 16, and a list 5 deep works, hitting a nesting of 15. However, with 6 levels, we need a max_nesting of 21 or greater.
    Jason DeLeon committed May 20, 2017
    Configuration menu
    Copy the full SHA
    e094aaf View commit details
    Browse the repository at this point in the history
  3. Update changelog to indicate fix for vmg#615

    Jason DeLeon committed May 20, 2017
    Configuration menu
    Copy the full SHA
    9a9a0ac View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2017

  1. Configuration menu
    Copy the full SHA
    c45bcf1 View commit details
    Browse the repository at this point in the history