Improve code and make crate a no_std crate #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, rebase it. I will publish new version. |
Changes: * all: use full words for `extension` and `mime_type` * extension: remove unwrap * lookup: simplify extension extraction * lookup: simplify mime_type extraction * extensions: simplify implementation * extensions: return an Iterator instead of a Vec * rust: make into a no_std crate
|
Rebased. Let me know what you think of bojand/infer#24. We are interested in having an easy way for users to use both the |
|
Ok, I'm interested in that. I will read the full text tomorrow. :) Released in v1.0.0. |
|
😱 v1.0 we were thinking about doing other changes after this |
|
I guess it could also work this way. What do you think @ririsoft |
|
@paolobarbolini It's a breaking change, so I think that is ok. |
|
The thing I was preoccupying for was the possibility of doing further breaking changes @fundon. Anyway, maybe it could also work this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to go with all changes in a single PR, let me know if you are ok with that.
The only breaking change is
extensionsreturning anIteratorinstead ofVec