feat: Provide Module-specific Logger
#904
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces `log`-member to Modules, so logs can be filtered by module and are also printed so to the local formatter, using 'Module: message'. No need to import logging to all your ViUR modules anymore, just use `self.log`.
phorward
force-pushed
the
feat-Module.log
branch
from
7dacb4b
to
868c5f3
Compare
phorward
changed the title
Module-specific Logger
sveneberth
requested changes
Oct 13, 2023
| @@ -110,6 +110,10 @@ def format(self, record: logging.LogRecord) -> str: | |||
|
|
|||
| record.pathname = pathname | |||
|
|
|||
| # Show logger-name before message when not "root" logger | |||
| if record.name != "root": | |||
There was a problem hiding this comment.
Sorry, but this condition is not good. This effects all other loggers. Not only the module-loggers.
The logging in the viur-core is general kinda hackish. Using the root logger is a bad practise, because usually all loggers of other packages propagates to it. Which results in workaround like this.
I have long wanted to rework the logging and work with sub loggers... Maybe this would be a good time to combine this. Give me a bit of time to evaluate and get this done.
There was a problem hiding this comment.
Ok, let's put this thing on hold. You can also create a follow-up PR based on this, if it's easier.
phorward
added
Priority: Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
log-member to Modules, so logs can be filtered by module and are also printed so to the local formatter, using 'Module: message'. No need to import logging to all your ViUR modules anymore, just useself.log.