feat: Add EmailTransportMailjet to email.py
#1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveneberth
requested changes
May 14, 2024
There was a problem hiding this comment.
Hey @bb-mausbrand,
thanks for your contributing.
Since you are new, a few words about the syntax:
- We use a linter that runs via GitHub Action, locally you can start it with
pipenv run pep8check— after you have installed your pipenv (you seem to have done that already). Please correct what he complains about :) - We generally use double quotes (
"), not single (') for strings.
And a few comments on the content, in addition to the other comments:
- Please regenerate the
requirements.txtonce after you have changed packages. Otherwise they will not be in the python wheel later.@phorward We could think about making thepipenv install --dev pipenv requirements --hash > src/viur/core/requirements.txtmailjet-restpackage an extra. That way it won't be installed if you don't need it. - Please add
conf.email.mailjet_api_keyandconf.email.mailjet_api_secretto the config object.
sveneberth
added
feature
sveneberth
changed the title
EmailTransportMailjet to email.py
lock versions of new packages in Pipfile
phorward
previously approved these changes
May 15, 2024
phorward
requested changes
May 15, 2024
There was a problem hiding this comment.
@phorward We could think about making the
mailjet-restpackage an extra. That way it won't be installed if you don't need it.
@bb-mausbrand can you please find out how to define extras as dependencies, and maybe tie it together with the pipenv-based tooling (see CONTRIBUTING.md for a short explanation).
phorward
requested changes
May 15, 2024
There was a problem hiding this comment.
Hello @bb-mausbrand,
I've found some issues regarding the final pull request. Can you check them out?
phorward
previously approved these changes
May 15, 2024
sveneberth
requested changes
May 15, 2024
remove extra modules from `Pipfile` add extra modules to `setup.cfg` update `requirements.txt`
sveneberth
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.