refactor: remove old and outdated examples #5611

sheremet-va · 2024-04-24T13:17:06Z

Description

This PR removes old, outdated, or duplicated (like 4 react ones) examples.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2024-04-24T13:17:21Z

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name	Link
🔨 Latest commit	`2e33004`
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6630bddd2c458d0008e42b65

sheremet-va · 2024-04-24T13:17:44Z

examples/README.md

@@ -2,26 +2,14 @@
 |---|---|---|
 | `basic` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/basic) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/basic?initialPath=__vitest__/) |
 | `fastify` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/fastify) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/fastify?initialPath=__vitest__/) |
-| `graphql` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/graphql) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/graphql?initialPath=__vitest__/) |


This example is very useless, it just checks that query is imported

sheremet-va · 2024-04-24T13:18:17Z

examples/README.md

@@ -2,26 +2,14 @@
 |---|---|---|
 | `basic` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/basic) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/basic?initialPath=__vitest__/) |
 | `fastify` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/fastify) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/fastify?initialPath=__vitest__/) |
-| `graphql` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/graphql) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/graphql?initialPath=__vitest__/) |
-| `image-snapshot` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/image-snapshot) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/image-snapshot?initialPath=__vitest__/) |


This example should be part of the image-snapshot README, and not implemented in Vitest repo

sheremet-va · 2024-04-24T13:18:29Z

examples/README.md

 | `lit` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/lit) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/lit?initialPath=__vitest__/) |
 | `marko` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/marko) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/marko?initialPath=__vitest__/) |
-| `mocks` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/mocks) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/mocks?initialPath=__vitest__/) |


This is moved to tests

sheremet-va · 2024-04-24T13:19:03Z

examples/README.md

 | `nestjs` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/nestjs) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/nestjs?initialPath=__vitest__/) |
 | `nextjs` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/nextjs) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/nextjs?initialPath=__vitest__/) |
-| `playwright` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/playwright) | |


I don't know if it is a good idea to promote this way of testing with playwright, - just use playwright-test?

sheremet-va · 2024-04-24T13:19:18Z

examples/README.md

 | `nestjs` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/nestjs) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/nestjs?initialPath=__vitest__/) |
 | `nextjs` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/nextjs) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/nextjs?initialPath=__vitest__/) |
-| `playwright` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/playwright) | |
-| `preact-testing-lib` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/preact-testing-lib) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/preact-testing-lib?initialPath=__vitest__/) |


This was just renamed to preact

sheremet-va · 2024-04-24T13:19:31Z

examples/README.md

-| `react-storybook` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/react-storybook) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/react-storybook?initialPath=__vitest__/) |
-| `react-testing-lib-msw` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/react-testing-lib-msw) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/react-testing-lib-msw?initialPath=__vitest__/) |
-| `react-testing-lib` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/react-testing-lib) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/react-testing-lib?initialPath=__vitest__/) |
+| `preact` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/preact) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/preact?initialPath=__vitest__/) |
 | `react` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/react) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/react?initialPath=__vitest__/) |


I removed all react ones except a single one. Doesn't seem fair that it's so over represented

Probably we should provide testing library example instead since the official react-test-renderer is being deprecated https://github.com/facebook/react/tree/d779eba4b375134f373b7dfb9ea98d01c84bc48e/packages/react-test-renderer

Can you swap two examples/react and examples/react-testing-lib?

Oh, actually you have testing-library in examples/react. All good 👍

Yeah, I rewrote it

sheremet-va · 2024-04-24T13:19:57Z

examples/README.md

 | `react` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/react) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/react?initialPath=__vitest__/) |
-| `ruby` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/ruby) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/ruby?initialPath=__vitest__/) |


This was just a test for base, we already have it

sheremet-va · 2024-04-24T13:20:30Z

examples/README.md

 | `solid` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/solid) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/solid?initialPath=__vitest__/) |
-| `svelte` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/svelte) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/svelte?initialPath=__vitest__/) |
 | `sveltekit` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/sveltekit) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/sveltekit?initialPath=__vitest__/) |


I think leaving only sveltekit should be ok. We have this because svelte fails a lot, but maybe it's better to move to the ecosystem-ci

sheremet-va · 2024-04-24T13:20:45Z

examples/README.md

 | `sveltekit` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/sveltekit) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/sveltekit?initialPath=__vitest__/) |
 | `typecheck` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/typecheck) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/typecheck?initialPath=__vitest__/) |
-| `vitesse` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/vitesse) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/vitesse?initialPath=__vitest__/) |
-| `vue-jsx` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/vue-jsx) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/vue-jsx?initialPath=__vitest__/) |
 | `vue` | [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/vue) | [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/vue?initialPath=__vitest__/) |


I think it's better to have a single vue example

hi-ogawa

Looks good to me! Can you fix conflict?

…eady checks it

sheremet-va commented Apr 24, 2024

View reviewed changes

hi-ogawa reviewed Apr 30, 2024

View reviewed changes

sheremet-va added 15 commits April 30, 2024 09:11

refactor: remove old and outdated examples

8f1f907

refactor: improve react example by using @testing-library

ab6929c

refactor: update versions in fastify example

a593de8

refactor: use fastify+react in workspace examples

cacbc00

refactor: update marko example

708f6e7

chore: add cleanup to react example

36c7e55

chore: remove beforeEach in nestjs example

9522a82

chore: add comment to lit test example

b5afd3a

refactor: add extension to preact example

42621e8

chore: remove nextjs/nestjs examples

d719573

test: add decorator hang test

b550452

test: fix test

9c38820

chore: name test

d219ac8

chore: remove vue example

6c535d6

test: move mocks example to core tests

b6ce2d4

sheremet-va force-pushed the examples/remove-outdated branch from 337791c to b6ce2d4 Compare April 30, 2024 07:50

sheremet-va added 3 commits April 30, 2024 10:07

chore: fix lock

709a8c3

chore: fix urls

5494652

test: fix import path

a5532c6

sheremet-va added 6 commits April 30, 2024 11:18

chore: fix type errors, remove decorator test since coverage-test alr…

8f003fd

…eady checks it

chore: last type error

331d07b

chore: update examples md

c93d1ca

chore: update preact dependencies

56fffd3

chore: fix workspace example

90ae21c

chore: test fix

2e33004

sheremet-va merged commit 959247e into vitest-dev:main Apr 30, 2024
19 checks passed

sheremet-va deleted the examples/remove-outdated branch April 30, 2024 10:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove old and outdated examples #5611

refactor: remove old and outdated examples #5611

sheremet-va commented Apr 24, 2024

netlify bot commented Apr 24, 2024 •

edited

sheremet-va Apr 24, 2024

sheremet-va Apr 24, 2024

sheremet-va Apr 24, 2024

sheremet-va Apr 24, 2024

sheremet-va Apr 24, 2024

sheremet-va Apr 24, 2024 •

edited

hi-ogawa Apr 30, 2024

hi-ogawa Apr 30, 2024

sheremet-va Apr 30, 2024

sheremet-va Apr 24, 2024

sheremet-va Apr 24, 2024

sheremet-va Apr 24, 2024

hi-ogawa left a comment

		\| `react` \| [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/react) \| [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/react?initialPath=__vitest__/) \|
		\| `ruby` \| [GitHub](https://github.com/vitest-dev/vitest/tree/main/examples/ruby) \| [Play Online](https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/ruby?initialPath=__vitest__/) \|

refactor: remove old and outdated examples #5611

refactor: remove old and outdated examples #5611

Conversation

sheremet-va commented Apr 24, 2024

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

netlify bot commented Apr 24, 2024 • edited

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sheremet-va Apr 24, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hi-ogawa left a comment

Choose a reason for hiding this comment

netlify bot commented Apr 24, 2024 •

edited

sheremet-va Apr 24, 2024 •

edited