Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove --segfault-retry #5514

Merged

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Apr 9, 2024

Description

it is time. --segfault-retry was a hacky solution we used because of segfaults on older Node.js version. We now have --pool=forks which is a better alternative.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va changed the title feat: remove --segfault-retry feat!: remove --segfault-retry Apr 9, 2024
@sheremet-va sheremet-va added this to the 2.0.0 milestone Apr 9, 2024
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 7e4f1d3
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6638a43e04b5650008f7a6fa

@sheremet-va sheremet-va force-pushed the feat/deprecate-segfault-retry branch from 8a23c9f to bfaf030 Compare May 6, 2024 09:34
@sheremet-va sheremet-va merged commit ed60e40 into vitest-dev:main May 6, 2024
16 of 19 checks passed
@sheremet-va sheremet-va deleted the feat/deprecate-segfault-retry branch May 6, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant