Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): update react-storybook example to storybook v8 #5467

Closed

Conversation

shilman
Copy link

@shilman shilman commented Apr 1, 2024

Description

This PR updates examples/react-storybook to Storybook v8.

The current example uses v6, and Storybook has progressed a lot since then. With respect to testing, the package @storybook/testing-react has been deprecated and the functionality has been moved to @storybook/react and dramatically improved.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit f6cd9f0
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/660ad4736f97ea00089638a0
😎 Deploy Preview https://deploy-preview-5467--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va
Copy link
Member

Thank you! We do need to go through examples and remove some of them.

@hi-ogawa
Copy link
Contributor

hi-ogawa commented Apr 3, 2024

react v17 and react-query v3 (the latest would be @tanstack/react-query v5) are probably old for a modern app. If it's not too much change, then it would be great to upgrade them too.

@shilman
Copy link
Author

shilman commented Apr 5, 2024

Thanks @sheremet-va ! We've done a lot of work to make Storybook stories more compatible with Vitest, and will hopefully have a small documentation PR coming your way soon.

Thanks @hi-ogawa -- good spot, I'll try to upgrade those too.

Will try to get this PR over the line in the next week or so. Thanks for your patience and for building such a wonderful tool! 🙏

@sheremet-va
Copy link
Member

We removed some duplicate examples including react-storybook.

@sheremet-va sheremet-va closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants