Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): remove enforce from vitest:browser plugin to simplify custom middleware plugin usage #4709

Closed

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 9, 2023

Description

Close #3743

I wasn't sure if Vitest side change is worth it for this issue since currently user-side workaround exists, but I created this PR as this demonstrates the reproduction and allows quick experiment.


Actually crossOriginIsolated might not be working for some browsers on CI. I will look into this further.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit f43756c
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65754185bc47360008ac5428

@hi-ogawa hi-ogawa changed the title fix(browser): remove "vitest:browser" plugin enforce for simpler custom middleware plugin integration fix(browser): remove enforce from vitest:browser plugin for simpler custom middleware plugin integration Dec 9, 2023
@hi-ogawa hi-ogawa changed the title fix(browser): remove enforce from vitest:browser plugin for simpler custom middleware plugin integration fix(browser): remove enforce from vitest:browser plugin to simplify custom middleware plugin usage Dec 9, 2023
@hi-ogawa
Copy link
Contributor Author

I suppose user-side workaround suffices and committing coop/coep tests might be an unnecessary burden.
Also, I cannot setup playwright/webkit locally on my archlinux PC, so it's hard to debug the issue.

I'm closing this PR for now, but feel free to pick up changes if it's considered important.

@hi-ogawa hi-ogawa closed this Dec 10, 2023
@hi-ogawa hi-ogawa deleted the fix-relax-vitest-browser-enforce branch December 10, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting HTTP response headers for browser tests
1 participant