Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always show filename for unhandled errors #2689

Merged
merged 2 commits into from Jan 16, 2023
Merged

fix: always show filename for unhandled errors #2689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d76a1ae
chore: fix typo
sheremet-va Jan 16, 2023
8672305
fix: always show filename for unhandled errors
sheremet-va Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/vitest/src/node/error.ts
View file
Open in desktop
Expand Up @@ -69,10 +69,10 @@ export async function printError(error: unknown, ctx: Vitest, options: PrintErro
const testPath = (e as any).VITEST_TEST_PATH
const testName = (e as any).VITEST_TEST_NAME
// testName has testPath inside
if (testPath && !testName)
if (testPath)
ctx.logger.error(c.red(`This error originated in "${c.bold(testPath)}" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.`))
if (testName) {
ctx.logger.error(c.red(`The latest test that migh've cause the error is "${c.bold(testName)}". It might mean one of the following:`
ctx.logger.error(c.red(`The latest test that might've caused the error is "${c.bold(testName)}". It might mean one of the following:`
+ '\n- The error was thrown, while Vitest was running this test.'
+ '\n- This was the last recorder test before the error was thrown, if error originated after test finished its execution.'))
}
Expand All @@ -84,7 +84,7 @@ export async function printError(error: unknown, ctx: Vitest, options: PrintErro

handleImportOutsideModuleError(e.stack || e.stackStr || '', ctx)

// Eg. AssertionError from assert does not set showDiff but has both actual and expected properties
// E.g. AssertionError from assert does not set showDiff but has both actual and expected properties
if (e.showDiff || (e.showDiff === undefined && e.actual && e.expected)) {
displayDiff(stringify(e.actual), stringify(e.expected), ctx.logger.console, {
outputTruncateLength: ctx.config.outputTruncateLength,
Expand Down