Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: terminate workers, when closing process #2645

Merged
merged 2 commits into from Jan 11, 2023
Merged

fix: terminate workers, when closing process #2645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce6e21f
feat: destroy workers, when closing process
sheremet-va Jan 11, 2023
4b1cc7b
chore: terminate all workers when closing pool
sheremet-va Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/vitest/src/node/pool.ts
View file
Open in desktop
Expand Up @@ -127,7 +127,9 @@ export function createPool(ctx: Vitest): WorkerPool {

return {
runTests: runWithFiles('run'),
close: async () => {}, // TODO: not sure why this will cause Node crash: pool.destroy(),
close: async () => {
await Promise.all(pool.threads.map(w => w.terminate()))
},
}
}

Expand Down