Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type issue with spyOn method (fix #2365) #2582

Merged
merged 3 commits into from Jan 9, 2023
Merged

fix: type issue with spyOn method (fix #2365) #2582

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e17308
Fixing type issue with spyOn method
samkevin1 Dec 30, 2022
fa8c631
Adding tests
samkevin1 Jan 2, 2023
ff7d452
Merge branch 'main' of github.com:vitest-dev/vitest into fix-spyOn-types
samkevin1 Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vitest/src/integrations/spy.ts
View file
Open in desktop
Expand Up @@ -154,10 +154,10 @@ export function spyOn<T, G extends Properties<Required<T>>>(
methodName: G,
accessType: 'set',
): SpyInstance<[T[G]], void>
export function spyOn<T, M extends (Methods<Required<T>> | Classes<Required<T>>)>(
export function spyOn<T, M extends (Classes<Required<T>> | Methods<Required<T>>)>(
obj: T,
methodName: M,
): Required<T>[M] extends (...args: infer A) => infer R | (new (...args: infer A) => infer R) ? SpyInstance<A, R> : never
): Required<T>[M] extends ({ new (...args: infer A): infer R }) | ((...args: infer A) => infer R) ? SpyInstance<A, R> : never
export function spyOn<T, K extends keyof T>(
obj: T,
method: K,
Expand Down