Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add tests summary in the dashboard #2133

Merged
merged 5 commits into from Oct 14, 2022
Merged

feat(ui): add tests summary in the dashboard #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a3f76e
feat(ui): add tests summary in the dashboard
webfansplz Oct 11, 2022
bdb783f
chore: update
webfansplz Oct 13, 2022
d8441c3
chore: remove divider
userquin Oct 13, 2022
dd9b389
chore: add min width to avoid flickering
userquin Oct 13, 2022
85c330e
chore: remove tail selector from dashboard cy test
userquin Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/ui/client/components/dashboard/DashboardEntry.cy.tsx
View file
Open in desktop
Expand Up @@ -5,20 +5,20 @@ const body = () => (<div data-testid="body-content">{ faker.lorem.words(2) }</di
const header = () => (<div data-testid="header-content">{ faker.hacker.phrase() }</div>)
const bodySelector = '[data-testid=body-content]'
const headerSelector = '[data-testid=header-content]'
const tailSelector = '[data-testid=tail]'
// const tailSelector = '[data-testid=tail]'

describe('DashboardEntry', () => {
it('tail is rendered by default', () => {
cy.mount(<DashboardEntry v-slots={{ body, header }}/>)
.get(tailSelector)
.should('exist')
})
// it('tail is rendered by default', () => {
// cy.mount(<DashboardEntry v-slots={{ body, header }}/>)
// .get(tailSelector)
// .should('exist')
// })

it('tail is not shown when true', () => {
cy.mount(<DashboardEntry tail v-slots={{ body, header }}/>)
.get(tailSelector)
.should('not.exist')
})
// it('tail is not shown when true', () => {
// cy.mount(<DashboardEntry tail v-slots={{ body, header }}/>)
// .get(tailSelector)
// .should('not.exist')
// })

it('renders the body and header slots', () => {
cy.mount(<DashboardEntry v-slots={{ body, header }}/>)
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/client/components/dashboard/DashboardEntry.vue
View file
Open in desktop
Expand Up @@ -5,13 +5,15 @@ withDefaults(defineProps<{ tail?: boolean }>(), { tail: false })
<template>
<div p-2 text-center flex>
<div>
<div text-4xl>
<div text-4xl min-w-2em>
<slot name="body" />
</div>
<div text-md>
<slot name="header" />
</div>
</div>
<div v-if="!tail" data-testid="tail" my-2 op50 w-1px bg-current origin-center rotate-15 translate-x-3 />
<!--
<div v-if="!tail" data-testid="tail" my-0 op50 w-2px bg-current origin-center rotate-0 translate-x-3 />
-->
</div>
</template>
12 changes: 6 additions & 6 deletions packages/ui/client/components/dashboard/TestsFilesContainer.vue
View file
Open in desktop
@@ -1,10 +1,10 @@
<template>
<div gap-0 flex="~ col gap-4" h-full justify-center items-center>
<div bg-header rounded-lg p="y4 x2">
<!-- <section aria-labelledby="tests" m="y-4 x-2">
<TestsEntry />
</section> -->
<TestFilesEntry />
</div>
<!-- <div bg-header rounded-lg p="y4 x2"> -->
<section aria-labelledby="tests" m="y-4 x-2">
<TestsEntry />
</section>
<TestFilesEntry />
<!-- </div> -->
</div>
</template>