Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always use node condition #1919

Merged
merged 8 commits into from Oct 28, 2022
Merged

fix: always use node condition #1919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b4f6bea
fix: always use node condition
sheremet-va Aug 26, 2022
234feb4
test: test for importing a file in different environments
sheremet-va Aug 26, 2022
a7214ff
chore: add import to conditions
sheremet-va Aug 26, 2022
3cd5b80
chore: update lockfile
sheremet-va Aug 26, 2022
2060a6d
chore: lint
sheremet-va Aug 26, 2022
08ba2be
chore: fix lock
sheremet-va Oct 28, 2022
eea8e08
chore: add only "node" condition, import/require should be dynamicaly…
sheremet-va Oct 28, 2022
467bca0
chore: disable browserField in exports
sheremet-va Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@
"pnpm": {
"overrides": {
"esbuild": "^0.14.47",
"vite": "^3.1.0",
"vite": "^3.2.0",
"vitest": "workspace:*",
"rollup": "^2.79.0"
}
Expand Down
4 changes: 4 additions & 0 deletions packages/vitest/src/node/plugins/index.ts
View file
Open in desktop
Expand Up @@ -90,6 +90,10 @@ export async function VitestPlugin(options: UserConfig = {}, ctx = new Vitest('t
// setting this option can bypass that and fallback to cjs version
mainFields: [],
alias: preOptions.alias,
conditions: ['node'],
// eslint-disable-next-line @typescript-eslint/prefer-ts-expect-error
// @ts-ignore we support Vite ^3.0, but browserField is available in Vite ^3.2
browserField: false,
},
server: {
...preOptions.api,
Expand Down