-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add throat when running spec files #1481
Conversation
❌ Deploy Preview for vitest-dev failed.Built without sensitive environment variables
|
Sure. Replaced it. Also added comment to PR, if you didn't notice. |
904989d
to
629bf65
Compare
Closed in favor of #1482 |
I guess tinypool already has the queueing mechanism, probably this might be redundant. About the Segfault, I guess it's about some deep bug of Node, where even if this makes it less likely to appear (I doubt tho), it doesn't really fix the root cause. 🤔 |
It has, but we can't hook up to it.
Doesn't hurt to try. This bug is not reproducible with Jest, so we might have something wrong |
Maybe we can add this functionality to
|
Fixes
VITETS_POOL_ID
logic.I noticed no performance differences with this.
I think this might also help with segfalts and Node errors? I have a feeling that running them all might cause it, but I don't have anything to back up that claim.