Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add throat when running spec files #1481

Closed
wants to merge 2 commits into from

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Jun 14, 2022

Fixes VITETS_POOL_ID logic.

I noticed no performance differences with this.

I think this might also help with segfalts and Node errors? I have a feeling that running them all might cause it, but I don't have anything to back up that claim.

@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for vitest-dev failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 629bf65
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62a82842bfcd4e000afc8366

@sheremet-va sheremet-va marked this pull request as draft June 14, 2022 06:09
@antfu
Copy link
Member

antfu commented Jun 14, 2022

https://www.npmtrends.com/p-limit-vs-p-throttle-vs-promise-throttle-vs-throat

Maybe p-limit?

@sheremet-va sheremet-va marked this pull request as ready for review June 14, 2022 06:13
@sheremet-va sheremet-va requested a review from antfu June 14, 2022 06:14
@sheremet-va
Copy link
Member Author

https://www.npmtrends.com/p-limit-vs-p-throttle-vs-promise-throttle-vs-throat

Maybe p-limit?

Sure. Replaced it. Also added comment to PR, if you didn't notice.

@sheremet-va
Copy link
Member Author

Closed in favor of #1482

@antfu
Copy link
Member

antfu commented Jun 14, 2022

I guess tinypool already has the queueing mechanism, probably this might be redundant. About the Segfault, I guess it's about some deep bug of Node, where even if this makes it less likely to appear (I doubt tho), it doesn't really fix the root cause. 🤔

@sheremet-va
Copy link
Member Author

sheremet-va commented Jun 14, 2022

I guess tinypool already has the queueing mechanism, probably this might be redundant. About the Segfault, I guess it's about some deep bug of Node, where even if this makes it less likely to appear (I doubt tho), it doesn't really fix the root cause. 🤔

It has, but we can't hook up to it.

I guess it's about some deep bug of Node, where even if this makes it less likely to appear

Doesn't hurt to try. This bug is not reproducible with Jest, so we might have something wrong

@sheremet-va
Copy link
Member Author

It has, but we can't hook up to it.

Maybe we can add this functionality to tinypool?

Doesn't hurt to try.

react-enzym failed once in the new PR, but fixed in the second one. I fear this change might introduce flaky tests now :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants