New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve watcher performance, add forceRerunTriggers option #1424
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
What's |
"not smart" 👀 I've recently worked on a project involving dumb routers, so I thought why not 😄 Also, the name was proposed as a joke in discord :P |
Sorry for this terrible joke. 😂 If the default watch mode is "smart", maybe instead we could have a If the word
|
packages/vitest/src/node/core.ts
Outdated
if (this.config.watchIgnore) | ||
this.console.error(c.dim('ignore: ') + c.yellow(this.config.watchIgnore.join(comma))) | ||
if (this.config.watchExclude) | ||
this.console.error(c.dim('ignore: ') + c.yellow(this.config.watchExclude.join(comma))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.console.error(c.dim('ignore: ') + c.yellow(this.config.watchExclude.join(comma))) | |
this.console.error(c.dim('exclude: ') + c.yellow(this.config.watchExclude.join(comma))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think exclude
is a bit misleading. Renamed to watch exclude
This wasn't clear watching only the changelog |
Sorry, thank you for pointing that out. Will do better next time. |
Few things to note here:
watchIgnore
is renamed towatchExclude
watchExclude
now accepts only glob patternsforceRerunTriggers
optionforceRerunTriggers
accepts glob pattern for files, that if changed, will cause a full suite rerunforceRerunTriggers
respectswatchExclude