Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve deep equality check failing message for toBe #1383

Merged
merged 7 commits into from Jun 6, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 37 additions & 2 deletions packages/vitest/src/integrations/chai/jest-expect.ts
Expand Up @@ -129,9 +129,44 @@ export const JestChaiExpect: ChaiPlugin = (chai, utils) => {
})
def('toBe', function (expected) {
const actual = this._obj
const pass = Object.is(actual, expected)

let toBeMessage = 'expected #{this} to be #{exp} // Object.is equality'
if (!pass) {
let reminderMessage = 'If it should pass with deep equality, replace "toBe" with "toStrictEqual"\n\n'
const toStrictEqualPass = jestEquals(
actual,
expected,
[
iterableEquality,
typeEquality,
sparseArrayEquality,
arrayBufferEquality,
],
true,
)

if (toStrictEqualPass) {
toBeMessage = `${reminderMessage}expected #{this} to be [serializes to the same string] // Object.is equality`
}
else {
const toEqualPass = jestEquals(
actual,
expected,
[iterableEquality],
)

if (toEqualPass) {
reminderMessage = 'If it should pass with deep equality, replace "toBe" with "toEqual"\n\n'

toBeMessage = `${reminderMessage}expected #{this} to be [serializes to the same string] // Object.is equality`
sheremet-va marked this conversation as resolved.
Show resolved Hide resolved
}
}
}

return this.assert(
Object.is(actual, expected),
'expected #{this} to be #{exp} // Object.is equality',
pass,
toBeMessage,
'expected #{this} not to be #{exp} // Object.is equality',
expected,
actual,
Expand Down
47 changes: 47 additions & 0 deletions test/core/test/jest-expect.test.ts
@@ -1,5 +1,6 @@
/* eslint-disable comma-spacing */
/* eslint-disable no-sparse-arrays */
import { AssertionError } from 'assert'
import { describe, expect, it, vi } from 'vitest'

class TestError extends Error {}
Expand Down Expand Up @@ -549,6 +550,52 @@ describe('async expect', () => {
expect(error).toEqual(expectedError)
}
})

it('reminds users to use deep equality checks if they are comparing objects', () => {
const createAssertionError = (
deepEqualityName: string,
expected: string,
) => new AssertionError({
message: 'If it should pass with deep equality, '
+ `replace "toBe" with "${deepEqualityName}"\n\nexpected ${expected} `
+ 'to be [serializes to the same string] // Object.is equality',
})

const actual = { key: 'value' }
class FakeClass {}

const toStrictEqualError1 = createAssertionError('toStrictEqual', '{ key: \'value\' }')
try {
expect(actual).toBe({ ...actual })
}
catch (error) {
expect(error).toEqual(toStrictEqualError1)
}

const toStrictEqualError2 = createAssertionError('toStrictEqual', 'FakeClass{}')
try {
expect(new FakeClass()).toBe(new FakeClass())
}
catch (error) {
expect(error).toEqual(toStrictEqualError2)
}

const toEqualError1 = createAssertionError('toEqual', '{}')
try {
expect({}).toBe(new FakeClass())
}
catch (error) {
expect(error).toEqual(toEqualError1)
}

const toEqualError2 = createAssertionError('toEqual', 'FakeClass{}')
try {
expect(new FakeClass()).toBe({})
}
catch (error) {
expect(error).toEqual(toEqualError2)
}
})
})

it('timeout', () => new Promise(resolve => setTimeout(resolve, 500)))