Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close node.js server correctly in the puppeteer example #1257

Merged
merged 1 commit into from May 7, 2022
Merged

fix: close node.js server correctly in the puppeteer example #1257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/puppeteer/test/basic.test.ts
View file
Open in desktop
Expand Up @@ -17,7 +17,9 @@ describe('basic', async () => {

afterAll(async () => {
await browser.close()
await server.httpServer.close()
await new Promise<void>((resolve, reject) => {
server.httpServer.close(error => error ? reject(error) : resolve())
})
})

test('should have the correct title', async () => {
Expand Down