New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve id before loading from vite #1204
Merged
antfu
merged 14 commits into
vitest-dev:main
from
sheremet-va:fix/allow-loading-from-node-modules
May 7, 2022
Merged
fix: resolve id before loading from vite #1204
antfu
merged 14 commits into
vitest-dev:main
from
sheremet-va:fix/allow-loading-from-node-modules
May 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…fix/allow-loading-from-node-modules
For some reason some changes here stall the terminal. Will try to figure it out, when I have the time. |
…fix/allow-loading-from-node-modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only processing
imports
inside already transformed file. This PR tries to fixpath
, whenViteNode
is called directly (withexecuteId
orexecuteFile
)Fixes #1194
Fixes #1195