fix(snapshot): fix concurrent SnapshotClient.startCurrentRun with s…

…ame filepath

packages/snapshot/src/client.ts

@@ -53,19 +53,25 @@ export class SnapshotClient {
   constructor(private options: SnapshotClientOptions = {}) {}
 
   async startCurrentRun(filepath: string, name: string, options: SnapshotStateOptions) {
+    console.log("[SnapshotClient.startCurrentRun]", { filepath, name });
+
     this.filepath = filepath
     this.name = name
 
     if (this.snapshotState?.testFilePath !== filepath) {
       await this.finishCurrentRun()
 
+      // Need to move async `SnapshotState.create` outside of synchronous `Map.get/set` to support concurrent test, which does following:
+      //   Promise.all([client.startCurrentRun(file, name1), client.startCurrentRun(file, name2)])
+      // TODO: it should save redundant `SnapshotState.create` by tracking `Map<string, Promise<SnapshotState>>`
+      const created = await SnapshotState.create(
+        filepath,
+        options,
+      );
       if (!this.getSnapshotState(filepath)) {
         this.snapshotStateMap.set(
           filepath,
-          await SnapshotState.create(
-            filepath,
-            options,
-          ),
+          created,
         )
       }
       this.snapshotState = this.getSnapshotState(filepath)
@@ -86,6 +92,8 @@ export class SnapshotClient {
   }
 
   assert(options: AssertOptions): void {
+    console.log("[SnapshotClient.assert:in]", options);
+
     const {
       filepath = this.filepath,
       name = this.name,
@@ -135,6 +143,7 @@ export class SnapshotClient {
       inlineSnapshot,
       rawSnapshot,
     })
+    console.log("[SnapshotClient.assert:out]", { actual, expected, key, pass });
 
     if (!pass)
       throw createMismatchError(`Snapshot \`${key || 'unknown'}\` mismatched`, this.snapshotState?.expand, actual?.trim(), expected?.trim())
@@ -169,6 +178,7 @@ export class SnapshotClient {
     if (!this.snapshotState)
       return null
     const result = await this.snapshotState.pack()
+    console.log("[SnapshotClient.finishCurrentRun]", result);
 
     this.snapshotState = undefined
     return result

packages/snapshot/src/port/state.ts

@@ -94,6 +94,7 @@ export default class SnapshotState {
     testFilePath: string,
     options: SnapshotStateOptions,
   ) {
+    console.log("[SnapshotState.create]", { testFilePath });
     const snapshotPath = await options.snapshotEnvironment.resolvePath(testFilePath)
     const content = await options.snapshotEnvironment.readSnapshotFile(snapshotPath)
     return new SnapshotState(testFilePath, snapshotPath, content, options)
@@ -227,6 +228,15 @@ export default class SnapshotState {
     error,
     rawSnapshot,
   }: SnapshotMatchOptions): SnapshotReturnOptions {
+    console.log("[SnapshotState.match]", {
+      testName,
+      received,
+      key,
+      inlineSnapshot,
+      isInline,
+      error,
+      rawSnapshot
+    });
     this._counters.set(testName, (this._counters.get(testName) || 0) + 1)
     const count = Number(this._counters.get(testName))
 
@@ -261,6 +271,7 @@ export default class SnapshotState {
     const pass = expectedTrimmed === prepareExpected(receivedSerialized)
     const hasSnapshot = expected !== undefined
     const snapshotIsPersisted = isInline || this._fileExists || (rawSnapshot && rawSnapshot.content != null)
+    console.log("[SnapshotState.match:2]", { expected, pass, hasSnapshot, snapshotIsPersisted }, [this._updateSnapshot]);
 
     if (pass && !isInline && !rawSnapshot) {
       // Executing a snapshot file as JavaScript and writing the strings back
@@ -298,6 +309,7 @@ export default class SnapshotState {
         }
       }
       else {
+        console.log("@@@@@@@ this.added++")
         this._addSnapshot(key, receivedSerialized, { error, isInline, rawSnapshot })
         this.added++
       }
@@ -325,6 +337,7 @@ export default class SnapshotState {
         }
       }
       else {
+        console.log("@@@@@@@ this.matched++")
         this.matched++
         return {
           actual: '',

test/core/test/repro.test.ts

@@ -0,0 +1,16 @@
+import { it, beforeAll } from 'vitest';
+
+// a little trick to restore normal console.log to see genuine chronological order
+// https://github.com/vitest-dev/vitest/issues/1405#issuecomment-1858696036
+// beforeAll(async () => {
+//   const { Console } = await import("node:console");
+//   globalThis.console = new Console(process.stdout, process.stderr);
+// });
+
+it.concurrent('1st', ({ expect }) => {
+  expect("hi1").toMatchInlineSnapshot(`"hi1"`);
+});
+
+it.concurrent('2nd', ({ expect }) => {
+  expect("hi2").toMatchInlineSnapshot(`"hi2"`);
+});